activity-tracker: Fix parsing of user domains #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

progval wants to merge 1 commit into matrix-org:develop from progval:patch-1

progval commented May 10, 2023

Server names can contain a colon: https://spec.matrix.org/v1.6/appendices/#server-name


          activity-tracker: Fix parsing of user domains

4de83b7

Server names can contain a colon: https://spec.matrix.org/v1.6/appendices/#server-name

progval requested a review from a team as a code owner

May 10, 2023 17:51

Author

progval commented May 10, 2023

Signed-off-by: Valentin Lorentz <progval plus matrixsignoff at progval dot net>

Half-Shot requested changes

View reviewed changes

Contributor

Half-Shot left a comment

Seems okay, but needs a changelog. Ideally https://github.com/matrix-org/matrix-appservice-bridge/blob/11c447ed491a556b8e8d40e0b0a9fc7c90f71ccf/spec/unit/activity-tracker.spec.ts would be updated with a test case to check that these userids are still supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet